deps: eth-block-tracker@^8.0.0 -> @metamask/eth-block-tracker@^9.0.2 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Merged
7 tasks
legobeat
force-pushed
the
deps-eth-block-tracker-9
branch
from
0d476b8
to
74f629e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
legobeat
changed the title
Gudahtt
reviewed
May 23, 2024
test/util/helpers.ts
Outdated
| @@ -145,7 +145,6 @@ export function buildStubForBlockNumberRequest( | |||
| return { | |||
| request: { | |||
| method: 'eth_blockNumber', | |||
| params: [], | |||
There was a problem hiding this comment.
Hmm, with v9.0.2 we should be able to restore this. Though I'm not sure whether it matters
There was a problem hiding this comment.
Good call. It looks like it shouldn't matter but I'm better safe than sorry here so putting it back here as well so we don't have some subtle regression not break tests down the line.
There was a problem hiding this comment.
At least it's good to see it work fine with both variants after 9.0.2
Gudahtt
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
eth-block-trackerhas been renamed to@metamask/eth-block-tracker.This upgrades to the latest v9, which contains no breaking changes beyond the rename.
Also contains a bugfix for an issue with multiple redundant polling loops.
https://github.com/MetaMask/eth-block-tracker/blob/main/CHANGELOG.md
Related