Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message types #282

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Update message types #282

merged 4 commits into from
Jan 22, 2024

Conversation

hmalik88
Copy link
Contributor

Wallet middleware was incorrectly assigning TypedMessageParams as the type for eth_signTypedData message params. Updated the type and tests.

@hmalik88 hmalik88 requested a review from a team as a code owner January 22, 2024 20:04
mcmire
mcmire previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. (edit: oh, I see the test failures, okay, I'll check back in a bit)

@hmalik88 hmalik88 merged commit 5092082 into main Jan 22, 2024
17 checks passed
@hmalik88 hmalik88 deleted the hm/update-message-types branch January 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmalik88 @mcmire