Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signatureMethod property to MessageParams #273

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Dec 2, 2023

The signatureMethod property was introduced because it will be useful for signature insight snaps to determine which signature scheme to provide insights for. Currently this would be for all our supported signing methods, but in the future can be applied to registered signer snaps.

@hmalik88 hmalik88 requested a review from a team as a code owner December 2, 2023 15:20
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@hmalik88 hmalik88 merged commit 21701a6 into main Dec 6, 2023
17 checks passed
@hmalik88 hmalik88 deleted the hm/add-sigtype branch December 6, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants