Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): add back missing txData for signTransaction,sendTransaction #263

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix(wallet): add back missing txData for signTransaction,sendTransaction #263

merged 3 commits into from
Nov 6, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 26, 2023 •
edited by cryptodev-2s
Loading

@legobeat legobeat mentioned this pull request Oct 26, 2023
Closed
15 tasks
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Oct 26, 2023
@legobeat
DONTMERGE: patch in github.com/MetaMask/eth-json-rpc-middleware/pull/263
5304bbd
legobeat added a commit to legobeat/metamask-extension that referenced this pull request Oct 26, 2023
@legobeat
DONTMERGE: patch in github.com/MetaMask/eth-json-rpc-middleware/pull/263
b21e5fd
mcmire
mcmire reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I have looked through your previous commit and compared it to this PR, and it looks like these are the only two that needed to changed.

@mcmire
Copy link
Contributor

mcmire commented Oct 31, 2023

@legobeat Anything I can do to help you with this? I want to unblock the extension team so that they can upgrade this in the extension, so I'm happy to help you add the missing tests.

@cryptodev-2s
Copy link
Contributor

@mcmire I will work on the tests Tomorrow

@cryptodev-2s cryptodev-2s reopened this Nov 6, 2023
@cryptodev-2s cryptodev-2s marked this pull request as ready for review November 6, 2023 15:01
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner November 6, 2023 15:01
mcmire
mcmire approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mcmire mcmire merged commit abb9a20 into MetaMask:main Nov 6, 2023
16 checks passed
@mcmire mcmire mentioned this pull request Nov 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@mikesposito mikesposito Awaiting requested review from mikesposito

Assignees

@cryptodev-2s cryptodev-2s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

txParams getting overwritten in wallet middleware
3 participants
@legobeat @mcmire @cryptodev-2s