Expose SafeEventEmitterProvider type #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all of the types within `./src/utils/cache.ts` seemed to be solely related to caching. These have been extracted to a separate file, and the main file has been updated to export `SafeEventEmitterProvider` from this file.
|
Looks like this PR isn't in a reviewable state right now because |
This reverts commit e6552db.
|
@Gudahtt Okay, should be ready for review now. |
Gudahtt
reviewed
Apr 28, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the types within
./src/utils/cache.tsseemed to be solelyrelated to caching. These have been extracted to a separate file, and
the main file has been updated to export
SafeEventEmitterProviderfromthis file.
Fixes #126.