Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eth-block-tracker to dependencies #125

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Move eth-block-tracker to dependencies #125

merged 2 commits into from
Apr 27, 2022

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Apr 27, 2022

We are attempting to convert eth-json-rpc-infura, which relies on this
package, to TypeScript, and TypeScript is reporting errors resolving the
definition file for this package due to the types for
eth-block-tracker not being properly available. Moving it to
dependencies addresses this.


Fixes #123.

We are attempting to convert `eth-json-rpc-infura`, which relies on this
package, to TypeScript, and TypeScript is reporting errors resolving the
definition file for this package due to the types for
`eth-block-tracker` not being properly available. Moving it to
`dependencies` addresses this.
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 75b4aef into main Apr 27, 2022
@mcmire mcmire deleted the move-eth-block-tracker branch April 27, 2022 19:55
@mcmire mcmire mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth-block-tracker should be listed in dependencies, not devDependencies
2 participants