Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepublishOnly script #124

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix prepublishOnly script #124

merged 1 commit into from
Apr 27, 2022

Conversation

rekmarks
Copy link
Member

The prepublishOnly script was referencing a package script that no longer exists and, judging by its name, would be unnecessary anyway.

@rekmarks rekmarks requested a review from a team as a code owner April 27, 2022 18:08
mcmire
mcmire approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think Shane kept a test:nobuild at first in #118 and then I told him to remove it and didn't catch this. This makes sense though.

@rekmarks rekmarks merged commit 27a9327 into main Apr 27, 2022
@rekmarks rekmarks deleted the fix-prepublishonly branch April 27, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @mcmire