Replace lodash.flatmap
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
previously approved these changes
Feb 3, 2021
Gudahtt
force-pushed
the
replace-lodash-flatmap
branch
3 times, most recently
from
8286c7c
to
cf58df6
Compare
rekmarks
reviewed
Feb 5, 2021
`flatmap` is a great utility function, but, it didn't seem necessary here. The operation it was used for was trivial to implement using plain JavaScript. Removing this dependency leaves one less thing for us to update.
Gudahtt
force-pushed
the
replace-lodash-flatmap
branch
from
cf58df6
to
16dec2e
Compare
rekmarks
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flatmapis a great utility function, but, it didn't seem necessary here. The operation it was used for was trivial to implement using plain JavaScript. Removing this dependency leaves one less thing for us to update.