Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 1, 2023

Stays within semver-major to retain Node.js v14 support for now.

Only semver-major update (should still not be causing semver-major for eth-hd-keyring) here is @metamask/eth-sig-util@^5.0.2->^6.0.0: CHANGELOG

@socket-security
Copy link

socket-security bot commented Sep 1, 2023

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@ethereumjs/util 8.0.5 None +4 1.01 MB holgerd77
@types/node 18.7.11...18.14.6 None +0/-0 3.61 MB types
@metamask/eth-sig-util 5.1.0...6.0.0 None +0/-0 150 kB metamaskbot

@legobeat legobeat force-pushed the deps-bumps-202309 branch 2 times, most recently from 236c095 to ca68a02 Compare September 1, 2023 08:15
@socket-security
Copy link

socket-security bot commented Sep 1, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @chainsafe/as-sha256@0.3.1, case@1.6.3

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

legobeat commented Sep 1, 2023

@SocketSecurity ignore @chainsafe/as-sha256@0.3.1
@SocketSecurity ignore case@1.6.3

maintainership ok

@legobeat legobeat marked this pull request as ready for review September 1, 2023 08:23
@legobeat legobeat requested a review from a team as a code owner September 1, 2023 08:23
@legobeat legobeat added the type-dependencies Pull requests that update a dependency file label Sep 1, 2023
@legobeat legobeat requested a review from a team September 12, 2023 10:49
@legobeat legobeat requested review from a team and Mrtenz September 12, 2023 11:43
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving all the removed stuff from the lockfile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants