Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 26, 2023

@legobeat legobeat marked this pull request as ready for review September 26, 2023 18:59
@legobeat legobeat requested a review from a team as a code owner September 26, 2023 18:59
@legobeat legobeat requested review from a team and Gudahtt September 26, 2023 18:59
@socket-security
Copy link

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @jest/types@27.5.1, @tootallnate/once@1.1.2, jest-environment-jsdom@27.5.1, jest-jasmine2@27.5.1, supports-hyperlinks@2.3.0, source-map@0.7.4, form-data@3.0.1, fb-watchman@2.0.2, anymatch@3.1.3, querystringify@2.2.0, ws@7.5.9, jsdom@16.7.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @jest/types@27.5.1
@SocketSecurity ignore @tootallnate/once@1.1.2
@SocketSecurity ignore jest-environment-jsdom@27.5.1
@SocketSecurity ignore jest-jasmine2@27.5.1
@SocketSecurity ignore supports-hyperlinks@2.3.0
@SocketSecurity ignore source-map@0.7.4
@SocketSecurity ignore form-data@3.0.1
@SocketSecurity ignore fb-watchman@2.0.2
@SocketSecurity ignore anymatch@3.1.3
@SocketSecurity ignore querystringify@2.2.0
@SocketSecurity ignore ws@7.5.9
@SocketSecurity ignore jsdom@16.7.0

jest subdeps ok

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 6d61e99 into MetaMask:v6.x Sep 26, 2023
@legobeat legobeat mentioned this pull request Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants