Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 8, 2025

This release includes a few minor improvements across a few different packages.


Note

Publishes v14.1.0 across packages with TypeScript 5.6–5.8 support and several Jest/base ESLint rule adjustments.

  • Release: bump versions to 14.1.0 in root, @metamask/eslint-config, @metamask/eslint-config-jest, and @metamask/eslint-config-typescript.
  • Base (@metamask/eslint-config):
    • Loosen promise/catch-or-return and promise/param-names.
  • Jest (@metamask/eslint-config-jest):
    • Replace @typescript-eslint/unbound-method with jest/unbound-method.
    • Remove jest/no-conditional-in-test.
  • TypeScript (@metamask/eslint-config-typescript):
    • Add support for TypeScript 5.6.x–5.8.x.
    • Disable @typescript-eslint/no-unsafe-enum-comparison.
    • Loosen:
      • @typescript-eslint/prefer-promise-reject-errors (allow unknown).
      • @typescript-eslint/naming-convention (import names).
      • @typescript-eslint/switch-exhaustiveness-check (allow default).

Written by Cursor Bugbot for commit db61ab4. This will update automatically on new commits. Configure here.

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 4, 2025

The only blocker here is manual testing. I wanted to test this in core first, but I ran into some obstacles the last time I tried.

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 7, 2025

I tested this in core.

I did find some new errors from jest/unbound-method. That rule was enabled in #391. We had considered it non-breaking because it was strictly looser than @typescript-eslint/unbound-method, but @typescript-eslint/unbound-method was disabled in core.

I think it's still fair to consider this non-breaking, since it's looser than the previous ruleset. But in practice it might end up being breaking because of disabled rules.

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 10, 2025

I've updated the changelog to clarify that change, and explain why it's usually non-breaking but not always.

@Gudahtt Gudahtt marked this pull request as ready for review November 10, 2025 14:04
@Gudahtt Gudahtt requested a review from a team as a code owner November 10, 2025 14:04
@Gudahtt Gudahtt merged commit fe384a0 into main Nov 10, 2025
26 checks passed
@Gudahtt Gudahtt deleted the release/14.1.0 branch November 10, 2025 14:10
Gudahtt added a commit that referenced this pull request Nov 10, 2025
@Gudahtt Gudahtt mentioned this pull request Nov 10, 2025
Gudahtt added a commit that referenced this pull request Nov 10, 2025
Reverts #411, which had a publishing failure. We
will re-attempt after fixing the issue.
@Gudahtt Gudahtt mentioned this pull request Nov 10, 2025
Gudahtt added a commit that referenced this pull request Nov 10, 2025
This is a re-attempt at release 14.1.0, originally attempted here:
#411, but failed due to a
worklfow bug that has now been fixed (in #420)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Publishes 14.1.0 across base, TypeScript, and Jest configs with TS
5.6–5.8 support and several rule relaxations/adjustments.
> 
> - **Release `14.1.0`**
> - Bump versions in `package.json` and packages
(`@metamask/eslint-config`, `@metamask/eslint-config-typescript`,
`@metamask/eslint-config-jest`).
>   - Update changelog links to new tags.
> - **Base (`@metamask/eslint-config`)**
>   - Loosen `promise/catch-or-return` and `promise/param-names`.
> - **TypeScript (`@metamask/eslint-config-typescript`)**
>   - Add support for TypeScript `5.6.x–5.8.x`.
>   - Disable `@typescript-eslint/no-unsafe-enum-comparison`.
> - Loosen `@typescript-eslint/prefer-promise-reject-errors` (allow
`unknown`).
>   - Loosen `@typescript-eslint/naming-convention` for import names.
> - Loosen `@typescript-eslint/switch-exhaustiveness-check` to allow
`default`.
> - **Jest (`@metamask/eslint-config-jest`)**
> - Replace `@typescript-eslint/unbound-method` with
`jest/unbound-method` in tests.
>   - Remove `jest/no-conditional-in-test`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
590c1c4. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants