Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Conversation

@georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented May 2, 2024

Description

This PR focuses on cleaning up the Figma design token JSON file by removing any symbols or descriptors from token names, such as * or textual descriptors like "strong". This ensures a cleaner, more standardized naming convention across our design tokens which in turn will make it easier to automate and transform into JS and CSS.

Related Issues

  • Fixes: N/A

Manual Testing Steps

To verify the changes, follow these steps:

  1. Navigate to the updated Figma JSON file page.
  2. Use the search function to look for previously removed terms (e.g., *, "strong").
  3. Confirm that no such terms are present in the token names.

Screenshots/Recordings

Adding visual evidence of the changes can significantly enhance the review process. If applicable, please include screenshots or recordings that showcase the difference made by this PR.

Before

before720.mov

After

after720.mov

No remaining instances of *, soft or strong

Screenshot 2024-05-02 at 4 25 45 PM
Screenshot 2024-05-02 at 4 25 49 PM
Screenshot 2024-05-02 at 4 26 02 PM

Pre-merge Author Checklist

  • Adherence to MetaMask Coding Standards confirmed.
  • The problem and solution are clearly described in the PR.
  • Related issues are linked.
  • Manual testing steps are detailed.
  • Screenshots/recordings are included if applicable.
  • Tests are included if applicable.
  • Code is documented using JSDoc format if applicable.
  • The correct labels have been applied to the PR.
  • PR status is accurately set.

Pre-merge Reviewer Checklist

  • Manual testing of the PR has been conducted.
  • The PR meets all acceptance criteria described in the related issue(s).
  • Testing evidence (e.g., recordings, screenshots) is provided.

@georgewrmarshall georgewrmarshall self-assigned this May 2, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [03b22d3]

Storybook: Storybook

@metamaskbot
Copy link
Collaborator

Builds ready [1226528]

Storybook: Storybook

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label May 2, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 2, 2024 23:09
@georgewrmarshall georgewrmarshall requested review from a team and garrettbear May 2, 2024 23:09
@georgewrmarshall georgewrmarshall merged commit 6718d92 into main May 3, 2024
@georgewrmarshall georgewrmarshall deleted the fix/edit-json branch May 3, 2024 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-design-system All issues relating to design system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants