This repository was archived by the owner on Nov 26, 2024. It is now read-only.
196: update gh pages storybook build #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [50a1f80]
|
Collaborator
Builds ready [8dcecfa]
|
garrettbear
commented
Aug 23, 2022
| "workbench.colorCustomizations": { | ||
| "titleBar.activeBackground": "#037DD6", | ||
| "titleBar.activeForeground": "#ffffff" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This makes it easier to tell the difference between design tokens and extension on vscode
garrettbear
commented
Aug 23, 2022
| "@storybook/addon-links": "^6.5.10", | ||
| "@storybook/preset-scss": "^1.0.3", | ||
| "@storybook/react": "^6.5.10", | ||
| "@storybook/storybook-deployer": "^2.8.12", |
Contributor
Author
There was a problem hiding this comment.
Package for storybook-to-ghpages command. Same we are using on extension.
garrettbear
requested review from
Cal-L,
NidhiKJha,
brianacnguyen and
georgewrmarshall
georgewrmarshall
approved these changes
Aug 23, 2022
Collaborator
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Let's give it a shot 🎯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
Description
Fonts are broken on storybook github page.
Technical Details
Build process for github pages with storybook
Acceptance Criteria
Storybook github page should display correct font without needing it to be on your machine