This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Updated Light Theme Shadows to match Storybook #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akatori-Design
added
color
Collaborator
Builds ready [875670f]
|
Contributor
Author
|
reverted MD back to |
Collaborator
Builds ready [425e04e]
|
Contributor
Author
|
renamed |
Collaborator
Builds ready [fd7622b]
|
Contributor
Author
|
fixed danger shadow size to SM |
Collaborator
Builds ready [40d23ad]
|
Collaborator
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
One question about error/danger
Collaborator
Builds ready [782c110]
|
Collaborator
Builds ready [54e69f6]
|
georgewrmarshall
previously approved these changes
Jul 21, 2022
Collaborator
Builds ready [15cb813]
|
Collaborator
Builds ready [4778dc6]
|
| "spread": "0" | ||
| }, | ||
| "type": "boxShadow" | ||
| } |
Collaborator
There was a problem hiding this comment.
These are updates from figma so I guess the type has changed for shadow from a number to a string?
georgewrmarshall
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all light-theme shadow tokens to match the Storybook Spec.
Description
Added description with "Uses : " examples.
Values:
Updated LG, primary, danger to :