Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Conversation

@georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented May 20, 2022

Description

Adding npm package version and storybook badges to readme for quick discovery of published package version number and storybook github page

Screenshots

Screen Shot 2022-05-20 at 2 48 50 PM

Testing criteria

  • npm badge should go to npm package
  • storybook badge should go to storybook github page

@metamaskbot
Copy link
Collaborator

Builds ready [68d4e3a]

@georgewrmarshall georgewrmarshall self-assigned this May 20, 2022
@georgewrmarshall
Copy link
Collaborator Author

Hmm not sure if we need to merge before the version shows up? Not sure why it's not working when viewing raw file.

@georgewrmarshall georgewrmarshall requested a review from Cal-L May 20, 2022 21:50
@georgewrmarshall georgewrmarshall added documentation Improvements or additions to documentation code Issue related to code work labels May 20, 2022
@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 24, 2022 22:00
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner May 24, 2022 22:00
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall merged commit b5cbaec into main Jun 6, 2022
@georgewrmarshall georgewrmarshall deleted the adding-badge branch June 6, 2022 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

code Issue related to code work documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants