Skip to content

Conversation

@mcmire
Copy link
Contributor

@mcmire mcmire commented Dec 1, 2022

See diff.

@mcmire mcmire requested a review from a team as a code owner December 1, 2022 22:36
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! It appears that the providerConfig change was breaking in every package it affected, so I've left a few comments on that. We'll need to update changelogs and versions to reflect that. All of the other changes look great though

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 4de13fe into main Dec 2, 2022
@mcmire mcmire deleted the release/36.0.0 branch December 2, 2022 23:01
gantunesr pushed a commit that referenced this pull request Dec 8, 2022
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants