-
-
Notifications
You must be signed in to change notification settings - Fork 256
Expand contributor docs #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own: * The release process is different than other repos because it makes use of `create-release-branch` rather than the `create-release-pr` action. * Performing tasks (running tests, etc.) across the monorepo is different than with other repos because it takes advantage of workspaces. * Testing changes made to the monorepo in other projects is different because of the use of preview builds. This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections.
Closed
Mrtenz
reviewed
Nov 30, 2022
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
legobeat
reviewed
Nov 30, 2022
legobeat
reviewed
Nov 30, 2022
legobeat
reviewed
Nov 30, 2022
Gudahtt
reviewed
Dec 1, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Dec 1, 2022
Gudahtt
reviewed
Dec 1, 2022
Gudahtt
reviewed
Dec 1, 2022
Gudahtt
reviewed
Dec 1, 2022
Gudahtt
reviewed
Dec 1, 2022
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Dec 1, 2022
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
legobeat
approved these changes
Dec 1, 2022
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own: * The release process is different than other repos because it makes use of `create-release-branch` rather than the `create-release-pr` action. * Performing tasks (running tests, etc.) across the monorepo is different than with other repos because it takes advantage of workspaces. * Testing changes made to the monorepo in other projects is different because of the use of preview builds. This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections. Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own: * The release process is different than other repos because it makes use of `create-release-branch` rather than the `create-release-pr` action. * Performing tasks (running tests, etc.) across the monorepo is different than with other repos because it takes advantage of workspaces. * Testing changes made to the monorepo in other projects is different because of the use of preview builds. This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections. Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own: * The release process is different than other repos because it makes use of `create-release-branch` rather than the `create-release-pr` action. * Performing tasks (running tests, etc.) across the monorepo is different than with other repos because it takes advantage of workspaces. * Testing changes made to the monorepo in other projects is different because of the use of preview builds. This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections. Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monorepo works differently than other repos, and we want to make sure that contributors are able to use it on their own:
create-release-branchrather than thecreate-release-praction.This commit moves the existing contributor documentation which was formerly present in the README to a separate file and adds some more sections.