Skip to content

chore(base-data-service): improve constructor type safety - #9525

Draft
Gudahtt wants to merge 2 commits into
mainfrom
improve-base-data-service-type-safety
Draft

chore(base-data-service): improve constructor type safety#9525
Gudahtt wants to merge 2 commits into
mainfrom
improve-base-data-service-type-safety

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Jul 15, 2026

Copy link
Copy Markdown
Member

Explanation

Improve the constructor type safety by using conditional types to ensure the messenger passed in has the necessary actions/events.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Gudahtt
Gudahtt force-pushed the improve-base-data-service-type-safety branch from 30abcd5 to cd62a86 Compare July 15, 2026 17:34
@Gudahtt
Gudahtt force-pushed the improve-base-data-service-type-safety branch 2 times, most recently from dce9f19 to f7ce0a4 Compare July 28, 2026 17:07
@Gudahtt

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@Gudahtt
Gudahtt force-pushed the improve-base-data-service-type-safety branch from f7ce0a4 to 97f066f Compare July 28, 2026 17:40
@Gudahtt

Gudahtt commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

@metamaskbot publish-previews

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@7.5.5-preview-97f066f
@metamask-previews/accounts-controller@39.0.5-preview-97f066f
@metamask-previews/address-book-controller@7.1.2-preview-97f066f
@metamask-previews/ai-controllers@0.8.0-preview-97f066f
@metamask-previews/analytics-controller@1.2.1-preview-97f066f
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-97f066f
@metamask-previews/announcement-controller@8.1.0-preview-97f066f
@metamask-previews/app-metadata-controller@2.0.1-preview-97f066f
@metamask-previews/approval-controller@9.0.2-preview-97f066f
@metamask-previews/assets-controller@11.2.1-preview-97f066f
@metamask-previews/assets-controllers@110.0.0-preview-97f066f
@metamask-previews/authenticated-user-storage@3.0.1-preview-97f066f
@metamask-previews/base-controller@9.1.0-preview-97f066f
@metamask-previews/base-data-service@0.1.3-preview-97f066f
@metamask-previews/bitcoin-regtest-up@1.0.0-preview-97f066f
@metamask-previews/bridge-controller@78.0.0-preview-97f066f
@metamask-previews/bridge-status-controller@74.5.0-preview-97f066f
@metamask-previews/build-utils@3.0.4-preview-97f066f
@metamask-previews/chain-agnostic-permission@1.7.0-preview-97f066f
@metamask-previews/chomp-api-service@4.0.0-preview-97f066f
@metamask-previews/claims-controller@0.5.3-preview-97f066f
@metamask-previews/client-controller@1.0.1-preview-97f066f
@metamask-previews/client-utils@1.2.1-preview-97f066f
@metamask-previews/compliance-controller@2.1.0-preview-97f066f
@metamask-previews/composable-controller@12.0.1-preview-97f066f
@metamask-previews/config-registry-controller@0.4.1-preview-97f066f
@metamask-previews/connectivity-controller@0.3.0-preview-97f066f
@metamask-previews/controller-utils@12.3.0-preview-97f066f
@metamask-previews/core-backend@7.0.0-preview-97f066f
@metamask-previews/delegation-controller@3.0.2-preview-97f066f
@metamask-previews/earn-controller@12.2.2-preview-97f066f
@metamask-previews/eip-5792-middleware@3.0.5-preview-97f066f
@metamask-previews/eip-7702-internal-rpc-middleware@0.1.1-preview-97f066f
@metamask-previews/eip1193-permission-middleware@2.0.1-preview-97f066f
@metamask-previews/ens-controller@19.1.5-preview-97f066f
@metamask-previews/eth-block-tracker@15.0.1-preview-97f066f
@metamask-previews/eth-json-rpc-middleware@23.1.3-preview-97f066f
@metamask-previews/eth-json-rpc-provider@6.0.1-preview-97f066f
@metamask-previews/foundryup@1.0.1-preview-97f066f
@metamask-previews/gas-fee-controller@26.3.0-preview-97f066f
@metamask-previews/gator-permissions-controller@4.2.3-preview-97f066f
@metamask-previews/geolocation-controller@0.1.3-preview-97f066f
@metamask-previews/java-tron-up@1.0.0-preview-97f066f
@metamask-previews/json-rpc-engine@10.5.0-preview-97f066f
@metamask-previews/json-rpc-middleware-stream@8.0.8-preview-97f066f
@metamask-previews/keyring-controller@27.1.0-preview-97f066f
@metamask-previews/local-node-utils@1.0.0-preview-97f066f
@metamask-previews/logging-controller@8.0.2-preview-97f066f
@metamask-previews/message-manager@14.1.2-preview-97f066f
@metamask-previews/messenger@2.0.0-preview-97f066f
@metamask-previews/messenger-cli@0.2.0-preview-97f066f
@metamask-previews/money-account-api-data-service@0.4.0-preview-97f066f
@metamask-previews/money-account-balance-service@2.3.0-preview-97f066f
@metamask-previews/money-account-controller@0.3.3-preview-97f066f
@metamask-previews/money-account-upgrade-controller@3.0.0-preview-97f066f
@metamask-previews/multichain-account-service@13.0.0-preview-97f066f
@metamask-previews/multichain-api-middleware@4.0.1-preview-97f066f
@metamask-previews/multichain-network-controller@3.2.1-preview-97f066f
@metamask-previews/multichain-transactions-controller@7.1.1-preview-97f066f
@metamask-previews/name-controller@9.1.2-preview-97f066f
@metamask-previews/network-connection-banner-controller@0.1.0-preview-97f066f
@metamask-previews/network-controller@34.0.0-preview-97f066f
@metamask-previews/network-enablement-controller@5.6.0-preview-97f066f
@metamask-previews/notification-services-controller@26.0.0-preview-97f066f
@metamask-previews/passkey-controller@3.0.0-preview-97f066f
@metamask-previews/permission-controller@13.1.1-preview-97f066f
@metamask-previews/permission-log-controller@5.1.0-preview-97f066f
@metamask-previews/perps-controller@10.0.0-preview-97f066f
@metamask-previews/phishing-controller@17.3.0-preview-97f066f
@metamask-previews/platform-api-docs@0.0.0-preview-97f066f
@metamask-previews/polling-controller@16.0.8-preview-97f066f
@metamask-previews/preferences-controller@23.1.0-preview-97f066f
@metamask-previews/profile-metrics-controller@4.0.2-preview-97f066f
@metamask-previews/profile-sync-controller@28.3.0-preview-97f066f
@metamask-previews/ramps-controller@18.0.0-preview-97f066f
@metamask-previews/rate-limit-controller@7.0.1-preview-97f066f
@metamask-previews/react-data-query@0.2.2-preview-97f066f
@metamask-previews/remote-feature-flag-controller@4.2.2-preview-97f066f
@metamask-previews/sample-controllers@5.0.3-preview-97f066f
@metamask-previews/seedless-onboarding-controller@10.1.0-preview-97f066f
@metamask-previews/selected-network-controller@26.1.5-preview-97f066f
@metamask-previews/sentinel-api-service@1.0.0-preview-97f066f
@metamask-previews/shield-controller@5.1.3-preview-97f066f
@metamask-previews/signature-controller@39.2.7-preview-97f066f
@metamask-previews/smart-transactions-controller@25.0.1-preview-97f066f
@metamask-previews/snap-account-service@2.0.0-preview-97f066f
@metamask-previews/social-controllers@2.7.0-preview-97f066f
@metamask-previews/solana-test-validator-up@1.0.0-preview-97f066f
@metamask-previews/stellar-quickstart-up@0.0.0-preview-97f066f
@metamask-previews/storage-service@1.0.2-preview-97f066f
@metamask-previews/subscription-controller@6.2.1-preview-97f066f
@metamask-previews/transaction-controller@69.2.1-preview-97f066f
@metamask-previews/transaction-pay-controller@26.0.1-preview-97f066f
@metamask-previews/user-operation-controller@41.2.7-preview-97f066f
@metamask-previews/wallet@8.1.0-preview-97f066f
@metamask-previews/wallet-cli@0.0.0-preview-97f066f

Gudahtt added 2 commits August 4, 2026 14:01
Improve the constructor type safety by using conditional types to
ensure the messenger passed in has the necessary actions/events.
@Gudahtt
Gudahtt force-pushed the improve-base-data-service-type-safety branch from 97f066f to 4f95b83 Compare August 4, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant