Allow updateTransactionGasFees for unapproved or submitted transactions#8042
Open
vinistevam wants to merge 7 commits intomainfrom
Open
Allow updateTransactionGasFees for unapproved or submitted transactions#8042vinistevam wants to merge 7 commits intomainfrom
updateTransactionGasFees for unapproved or submitted transactions#8042vinistevam wants to merge 7 commits intomainfrom
Conversation
pedronfigueiredo
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
validateIfTransactionUnapprovedOrSubmittedinutils.tsand use it inupdateTransactionGasFeesso it accepts bothTransactionStatus.unapprovedandTransactionStatus.submitted.TransactionController.test.tsandutils.test.ts.updateTransactionGasFeesfor submitted as well as unapproved.References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/7051
Checklist
Note
Medium Risk
Changes a state-validation guard to permit mutating gas parameters after a tx is already
submitted, which could affect transaction lifecycle assumptions and downstream consumers. Scope is limited and covered by targeted unit tests.Overview
updateTransactionGasFeesnow permits transactions inTransactionStatus.submittedin addition tounapproved, using a newvalidateIfTransactionUnapprovedOrSubmittedhelper and updated error messaging.Adds unit coverage for the new validator and for successfully updating gas fields on a
submittedtransaction, and documents the behavior change in the transaction-controller changelog.Written by Cursor Bugbot for commit f983bd0. This will update automatically on new commits. Configure here.