Validate intent typedData in bridge quote responses#7895
Open
oscarwroche wants to merge 19 commits intofeat/intent-v2from
Open
Validate intent typedData in bridge quote responses#7895oscarwroche wants to merge 19 commits intofeat/intent-v2from
oscarwroche wants to merge 19 commits intofeat/intent-v2from
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
intent.typedDatafor intent swaps.typedData.domainandtypedData.messageto avoid deep type recursion while still checking structural EIP‑712 fields.References
Checklist
Note
Medium Risk
Medium risk because it changes intent-order submission to optionally sign EIP-712 data via
KeyringController, affecting transaction submission behavior and introducing a new failure mode whentypedDatais absent.Overview
Intent quote validation now accepts optional EIP-712
intent.typedDatapayloads (lightweight structural checks for required fields) when validating bridge quote responses.BridgeStatusController.submitIntentnow treatssignatureas optional: if omitted, it signs the providedintent.typedDatainternally viaKeyringController:signTypedMessage(V4); if bothsignatureandtypedDataare missing it throws. Updates messenger action typings accordingly and adds unit tests covering the autosign + missing-data error paths.Written by Cursor Bugbot for commit 60faf46. This will update automatically on new commits. Configure here.