feat: added 'getAccessToken' with refresh token if expired #7800
+341
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a new public method getAccessToken() with automatic token refresh capability to prevent clients from using expired access tokens when retrieving them from state.
Issue:
Previously, clients could directly access state.accessToken from the controller state, which could potentially return an expired token. This could lead to failed API calls and poor user experience when the token had expired but wasn't refreshed.
Solution:
Added a new public method
getAccessToken()that automatically refreshes expired tokens: Uses the #executeWithTokenRefresh wrapper to check token expiration and refresh if needed before returningReferences
Checklist
Note
Medium Risk
Adds a new public token-access path that can trigger refresh/auth flows; mistakes could surface as unexpected authentication errors or stale token usage for consumers.
Overview
Introduces a new public
getAccessToken()method (and messenger actionSeedlessOnboardingController:getAccessToken) so clients can fetch the currentaccessTokenwithout reading controller state directly.getAccessToken()is wrapped in the controller lock and uses the existing refresh flow to proactively refresh expired node/metadata/access tokens before returning an access token; the token-expiry checks were refactored into a shared#checkTokensExpired()helper. Tests were added to cover success, missing token, unauthenticated user, refresh-on-expiry, and refresh failure cases, and exports/types were reorganized so messenger/actions/options are defined/exported fromSeedlessOnboardingController.Written by Cursor Bugbot for commit 4594ee9. This will update automatically on new commits. Configure here.