feat: add network fallback mechanism to IncomingTransactionHelper #7759
+381
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingTransactionHelper
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.test.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
matthewwalsh0
requested changes
Jan 29, 2026
|
|
||
| this.#onInterval().catch((error) => { | ||
| log('Initial polling failed', error); | ||
| log('Polling failed', error); |
Member
There was a problem hiding this comment.
This was intentional to distinguish that the first attempt failed, rather than a future interval based one.
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
| }); | ||
| } | ||
| } else if (!this.#chainsToPoll.includes(hexChainId)) { | ||
| // status === 'down' |
Member
There was a problem hiding this comment.
Should we be explicit in case they ever add more statuses?
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
matthewwalsh0
previously approved these changes
Jan 30, 2026
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
matthewwalsh0
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In incoming transaction helper if any chain goes down on web sockets, start polling for it.
References
Fixes #12345
Checklist
Note
Medium Risk
Medium risk because it changes when/what chains are polled for incoming transactions and adds new event-driven state around network availability, which could impact transaction discovery if chain ID conversion or status handling is off.
Overview
When WebSocket-based incoming transaction retrieval is enabled,
IncomingTransactionHelpernow listens forAccountActivityService:statusChangedand starts/stops fallback polling based on which supported networks are reported down, polling only the affected chains.This threads an optional
chainIdsfilter throughRemoteTransactionSourceRequestand updatesAccountsApiRemoteTransactionSourceto query only those chains, plus adds tests and updatesTransactionController’s allowed events/types to include the new status event (and updates the changelog).Written by Cursor Bugbot for commit 72bf51c. This will update automatically on new commits. Configure here.