-
-
Notifications
You must be signed in to change notification settings - Fork 256
Release/692.0.0 #7221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release/692.0.0 #7221
Conversation
| ### Uncategorized | ||
|
|
||
| - Release 690.0.0 ([#7215](https://github.com/MetaMask/core/pull/7215)) | ||
| - Release/689.0.0 ([#7211](https://github.com/MetaMask/core/pull/7211)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Changelog references outdated monorepo release versions
The ## [92.0.0] section in the CHANGELOG references Release 690.0.0 and Release/689.0.0, but the current monorepo version is 692.0.0. These references appear to be stale entries from an earlier release that weren't updated when creating the new version 92.0.0 changelog section, potentially misleading users about which monorepo releases are included in this version bump.
| "@ethersproject/providers": "^5.7.0", | ||
| "@metamask/accounts-controller": "^35.0.0", | ||
| "@metamask/assets-controllers": "^91.0.0", | ||
| "@metamask/assets-controllers": "^92.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss, now that these have been moved into dependencies, does this mean we are responsible for bumping other teams packages and/or updating their changelogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is still required
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [92.0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahar-fehri as you’re introducing a breaking change do you have clients PRs ready ?
|
|
||
| ### Added | ||
|
|
||
| - **BREAKING:** Add optional JWT token authentication to multi-chain accounts API calls ([#7165](https://github.com/MetaMask/core/pull/7165)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the token is optional why did you decide to reference this as a breaking change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cryptodev-2s because a new action will be introduced on the messenger , that's why it's a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks make sense
|
@metamaskbot publish-preview |
Explanation
Release of assets-controllers
References
Checklist
Note
Publishes @metamask/assets-controllers v92.0.0 (optional JWT auth, dep adjustments, fixes) and updates dependent packages to ^92.0.0; bumps monorepo to 692.0.0.
Authorization: Bearer <token>when provided.TokenBalancesControlleraddress casing/state consistency issues.@metamask/assets-controllersto^92.0.0inpackages/bridge-controllerandpackages/transaction-pay-controller.692.0.0.Written by Cursor Bugbot for commit e6b00ff. This will update automatically on new commits. Configure here.