fix: controller send transaction approved when user reject transaction in hardware devices. #7214
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the transaction approval logic to check the status of the transaction. If the transaction fails due to user rejection or other errors, it now publishes a failure message with the error details. This change improves error handling and user feedback during transaction processing.
Contributor
Author
|
@metamaskbot publish-preview |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| transactionMeta: updatedTransactionMeta, | ||
| actionId, | ||
| error: updatedTransactionMeta?.error?.message ?? 'Unknown error', | ||
| }); |
There was a problem hiding this comment.
Bug: Duplicate transaction failed event publication
The transactionFailed event is published twice when a transaction fails during approval. The #approveTransaction method already calls #failTransaction which publishes the transactionFailed event, but the new code checks the status and publishes it again. This creates duplicate event emissions that could cause incorrect analytics tracking and unexpected behavior in event listeners.
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
matthewwalsh0
requested changes
Nov 21, 2025
|
|
||
| // need to check status of updatedTransactionMeta to see if it is approved | ||
| // for special case like user reject request in hardware wallet, the transactionMeta is failed with error "user rejected request" | ||
| if (updatedTransactionMeta.status === TransactionStatus.failed) { |
Member
There was a problem hiding this comment.
However the approval is rejected, it should already throw from this.#requestApproval above and be caught in the below catch meaning the approval event wouldn't fire?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix some issue caused by user reject transaction in hardware wallet, which cause a lot of incorrect event log in segment.
Updated the transaction approval logic to check the status of the transaction. If the transaction fails due to user rejection or other errors, it now publishes a failure message with the error details. This change improves error handling and user feedback during transaction processing.
Explanation
References
Checklist
Note
Ensure post-approval emits transactionFailed (with error) instead of transactionApproved when the transaction ends in failed status (e.g., hardware wallet rejection).
packages/transaction-controller/src/TransactionController.ts):updatedTransactionMeta.status; iffailed, publish${controllerName}:transactionFailedwitherrormessage, else publish${controllerName}:transactionApproved.Written by Cursor Bugbot for commit e0caebb. This will update automatically on new commits. Configure here.