fix: fix account state #7210
Draft
fix: fix account state #7210
+89
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
On mobile and extension, when AccountAPI is enabled, the token balances state ended up storing native+stake in a different area from erc-20.
Example:
{ "tokenBalances": { // lowercase address contains ERC-20 token balances "0xd5018bd3d94e23e71a2575206a1176d5c8637bec": { "0x1": { "0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48": "0x5337e0", "0xacA92E438df0B2401fF60dA7E4337B687a2435DA": "0x286e37", // ... }, }, // CheckSum address contains Native + Staked balances 💀 "0xd5018bD3d94e23e71A2575206a1176D5c8637BeC": { "0x1": { "0x0000000000000000000000000000000000000000": "0x445931076e034", "0x4FEF9D741011476750A243aC70b9789a63dd47Df": "0x0" }, } }Our aggregated balance calculations rely on the lowercase addresses for the token values, so this was why native and staked balances were missing.
The fix normalises the state data so that we merge both fields into the lowercase addresses.
References
Checklist