chore(bridge-controller): faster utils #7185
Open
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
While working on MetaMask/metamask-mobile#22744 I noticed that if do this small change of pre-converting values I can save up to 25% of time when looping though big array of tokens where this functions were used multiple times per one loop.
References
Checklist
Note
Precomputes chain ID string constants and uses them in
isSolanaChainId,isBitcoinChainId, andisTronChainIdwithinutils/bridge.ts.SOLANA_MAINNET_CHAIN_ID_STRING,SOLANA_CHAIN_ID_STRING,BITCOIN_MAINNET_CHAIN_ID_STRING,BITCOIN_CHAIN_ID_STRING,TRON_MAINNET_CHAIN_ID_STRING,TRON_CHAIN_ID_STRING.isSolanaChainId,isBitcoinChainId,isTronChainIdto compare against precomputed strings instead of inlinetoString()calls.Written by Cursor Bugbot for commit 68f77e1. This will update automatically on new commits. Configure here.