Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 17, 2025

Explanation

Update ts-jest to resolve peer dependency warning about the version of typescript we're using being too high.

The changelogs for the two breaking changes of ts-jest are here:

None of the breaking changes seem to impact us.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security
Copy link

socket-security bot commented Nov 17, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedjest-environment-jsdom@​27.5.1 ⏵ 28.1.310010066 +192100
Updatedjest-environment-node@​27.5.1 ⏵ 29.7.0100 +110066 +192100
Updatedjest@​27.5.1 ⏵ 28.1.310010068 +192100
Updated@​types/​jest@​27.5.2 ⏵ 28.1.8100 +110077 +181100
Updatedts-jest@​27.1.5 ⏵ 28.0.8971009490100

View full report

@socket-security
Copy link

socket-security bot commented Nov 17, 2025

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
Potential code anomaly (AI signal): npm http-proxy-agent is 100.0% likely to have a medium risk anomaly

Notes: The code fragment is a conventional HTTP proxy agent component handling optional proxy authentication and dynamic header adjustments. There is no evidence of malicious activity, data exfiltration, or supply-chain abuse within this fragment. The main concerns relate to reliance on internal Node.js fields (version fragility) and potential in-memory exposure of credentials, but these are standard operational caveats for proxy clients and do not indicate malice.

Confidence: 1.00

Severity: 0.60

From: ?npm/jest-environment-jsdom@28.1.3npm/http-proxy-agent@5.0.0

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/http-proxy-agent@5.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Ignoring alerts on:

  • tr46@3.0.0

View full report

@Gudahtt Gudahtt force-pushed the update-ts-jest branch 5 times, most recently from dd11f8d to 2d6186a Compare November 19, 2025 20:30
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 19, 2025

@SocketSecurity ignore npm/tr46@3.0.0

"new author" from 3 years ago is not a concern. Also this is a well known maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants