Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 6, 2025

Explanation

Updates the github-tools changelog-check workflow to fix detection of devDependencies-only changes in package.json.

What's Fixed

The previous version failed to properly detect when package.json changes were only in devDependencies because the git diff logic required both the start and end of the devDependencies section to be visible. With limited diff context (-U20), the closing brace was often not included in the diff output.

The new version increases git diff context from -U20 to -U9999 to ensure section headers are always visible, allowing proper detection of devDependencies-only changes.

Changes

  • Updated MetaMask/github-tools/.github/workflows/changelog-check.yml from fc6fe1a to bfb5e6f (PRs containing the fix PR1, PR2)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Updates the changelog-check GitHub Actions workflow to use MetaMask/github-tools commit c0ec1c3.

  • CI:
    • Update changelog-check reusable workflow reference and action-sha to c0ec1c3 in .github/workflows/changelog-check.yml.

Written by Cursor Bugbot for commit 44a036e. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner November 6, 2025 11:45
@cryptodev-2s cryptodev-2s self-assigned this Nov 6, 2025
@cryptodev-2s cryptodev-2s enabled auto-merge (squash) November 6, 2025 11:48
@cryptodev-2s cryptodev-2s merged commit adf0ca8 into main Nov 6, 2025
268 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/update-changelog-check-workflow-bfb5e6f branch November 6, 2025 13:26
cryptodev-2s added a commit that referenced this pull request Nov 6, 2025
cryptodev-2s added a commit that referenced this pull request Nov 6, 2025
…7077)

Reverts #7076

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Update `.github/workflows/changelog-check.yml` to use
`MetaMask/github-tools` changelog-check workflow at commit `fc6fe1a`
(including `action-sha`).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d7d9989. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants