fix: transaction pay quote refresh #7020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Ensure
isLoadingis also cleared after refreshing quotes.References
Checklist
Note
Centralizes isLoading lifecycle in
updateQuotesto avoid infinite loading after quote refresh, updates controller logic, tests, and changelog.src/utils/quotes.ts):transactionData.isLoading = trueat start ofupdateQuotes, and always clear it infinally.getStrategycall inside try; wrap quote fetching in try/catch and proceed with empty quotes on failure.quotes,quotesLastUpdated, andtotals.src/TransactionPayController.ts):isLoadingtoggling aroundupdateQuotes; rely on quotes util.refreshQuotes):isLoadingdirectly; delegate toupdateQuotes.isLoadinghandling and additional update callbacks (e.g., expect 3 calls, apply all callbacks).isLoading: falseafter updates.Written by Cursor Bugbot for commit 5d42563. This will update automatically on new commits. Configure here.