Skip to content

Conversation

@SteP-n-s
Copy link
Contributor

@SteP-n-s SteP-n-s commented Oct 29, 2025

Explanation

Updates logic of getBridgeERC20Allowance method to use chainId parameter to retrieve the networkClient.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Update getBridgeERC20Allowance to fetch the network client by chainId; add error handling/tests and update changelog.

  • BridgeController:
    • Add #getNetworkClientByChainId(chainId) to resolve client via NetworkController:findNetworkClientIdByChainId then getNetworkClientById.
    • Update getBridgeERC20Allowance to use #getNetworkClientByChainId instead of the selected network; throw on missing client/provider.
  • Tests (src/bridge-controller.test.ts):
    • Adjust mocks to expect findNetworkClientIdByChainIdgetNetworkClientById call sequence.
    • Add cases for missing network client and missing provider errors.
  • Docs:
    • Update CHANGELOG.md under Unreleased with the fix entry.

Written by Cursor Bugbot for commit 159d089. This will update automatically on new commits. Configure here.

@micaelae micaelae changed the title Refactor/update allowance logic fix: remove global network reference in bridge allowance handler Oct 29, 2025
@micaelae micaelae marked this pull request as ready for review October 29, 2025 16:50
@micaelae micaelae requested a review from a team as a code owner October 29, 2025 16:50
@micaelae micaelae requested a review from a team as a code owner October 29, 2025 16:50
@micaelae micaelae enabled auto-merge (squash) October 29, 2025 16:50
micaelae
micaelae previously approved these changes Oct 29, 2025
@micaelae micaelae merged commit 8a31998 into main Oct 29, 2025
255 checks passed
@micaelae micaelae deleted the refactor/update-allowance-logic branch October 29, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants