fix: remove global network reference in bridge allowance handler #6994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Updates logic of
getBridgeERC20Allowancemethod to usechainIdparameter to retrieve thenetworkClient.References
Checklist
Note
Update
getBridgeERC20Allowanceto fetch the network client bychainId; add error handling/tests and update changelog.#getNetworkClientByChainId(chainId)to resolve client viaNetworkController:findNetworkClientIdByChainIdthengetNetworkClientById.getBridgeERC20Allowanceto use#getNetworkClientByChainIdinstead of the selected network; throw on missing client/provider.src/bridge-controller.test.ts):findNetworkClientIdByChainId→getNetworkClientByIdcall sequence.CHANGELOG.mdunderUnreleasedwith the fix entry.Written by Cursor Bugbot for commit 159d089. This will update automatically on new commits. Configure here.