chore: Update obsolete property name in error message #6955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `INVALID_CONTROLLER_ERROR` error message incorrectly referenced the property name `messagingSystem`, which is no longer used in the next version of the `BaseController` class (which the `ComposableController` switched to in the PR `#6710). The error message was updated to no mention the messenger instance variable at all, since the check that triggered the error doesn't look for it anyway.
Gudahtt
force-pushed
the
remove-obsolete-property-reference-in-error-message
branch
from
bbe6a3a to
05b6cb3
Compare
Gudahtt
deleted the
remove-obsolete-property-reference-in-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
INVALID_CONTROLLER_ERRORerror message incorrectly referenced the property namemessagingSystem, which is no longer used in the next version of theBaseControllerclass (which theComposableControllerswitched to in the PR #6710).The error message was updated to no mention the messenger instance variable at all, since the check that triggered the error doesn't look for it anyway.
References
Fixes minor error introduced by #6710
Checklist
Note
Update
INVALID_CONTROLLER_ERRORto remove obsoletemessagingSystemreference, stating only that controllers must inherit fromBaseController.Written by Cursor Bugbot for commit 05b6cb3. This will update automatically on new commits. Configure here.