feat: changes to AccountTrackerController to enable migration in extension #6938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
force-pushed
the
disable-fetching
branch
from
63ea58a to
561d671
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bergarces
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
bergarces
commented
Oct 29, 2025
| tokenBalances: { | ||
| '0x0000000000000000000000000000000000000000': { | ||
| [CHECKSUM_ADDRESS_1]: new BN('123456', 16), | ||
| [ADDRESS_1]: new BN('123456', 16), |
There was a problem hiding this comment.
@salimtb I'd like your input here if possible.
From what I can see, if we use multicall (queryAllAccounts: true), the resulting addresses will be lowercase, but when we query a single address (queryAllAccounts: false) the result is a checksummed address.
Therefore, since I have changed the these two events to query multiple accounts (both the from and the to), I had to change this return value from the test.
Does that sound right?
salimtb
previously approved these changes
Oct 29, 2025
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
commented
Oct 30, 2025
| | { | ||
| type: 'PreferencesController:getState'; | ||
| handler: () => { isMultiAccountBalancesEnabled: boolean }; | ||
| } |
There was a problem hiding this comment.
This fixes type issues in clients, as the extension PreferencesController state is not compatible with core. We only care about isMultiAccountBalancesEnabled.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds optional callback to disable fetching balances in AccountTrackerController.
Attempts to refresh balance when a network is added and when the keyring is unlocked.
References
Checklist
Note
Adds optional fetchingEnabled gate, refreshes on networkAdded/unlock, and updates tx handlers to refresh both from/to addresses via new refreshAddresses; updates tests and changelog with breaking notes.
fetchingEnabledconstructor callback;refreshshort-circuits when disabled.NetworkController:networkAddedandKeyringController:unlockto trigger balance refreshes.fromandtovia newrefreshAddresses; remove single-address refresh path.PreferencesController:getStatetyping; remove legacyAccountsController:selectedAccountChangereference.networkAdded,unlock, and disabled fetching; address checksum fixes.fetchingEnabledoption.Written by Cursor Bugbot for commit 878ed7e. This will update automatically on new commits. Configure here.