feat: subscription sponsorship intents #6898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…onsorship-intents
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
tuna1207
reviewed
Oct 29, 2025
tuna1207
reviewed
Oct 29, 2025
tuna1207
reviewed
Oct 29, 2025
tuna1207
requested changes
Oct 29, 2025
tuna1207
previously approved these changes
Oct 29, 2025
tuna1207
approved these changes
Oct 29, 2025
chaitanyapotti
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added new method,
submitSponsorshipIntents, which submits the user's sponsorship intents for new subscription with crypto.References
Checklist
Note
Introduces submitSponsorshipIntents flow for crypto subscriptions, adds/validates cached crypto payment method data (including token symbol), and updates approve amount/pricing handling with new helpers and errors.
src/SubscriptionController.ts)submitSponsorshipIntents(registered via messenger) to submit gas-sponsorship intents using cached crypto payment method and pricing-derivedbillingCycles/recurringInterval.#assertIsPaymentMethodCrypto,#getProductPriceByProductAndPlan, and refine#assertIsUserNotSubscribedusingACTIVE_SUBSCRIPTION_STATUSES.cacheLastSelectedPaymentMethodnow requirespaymentTokenSymbolfor crypto; persistslastSelectedPaymentMethodper product.getTokenApproveAmountuses priceminBillingCycles, affectingapproveAmount.src/SubscriptionService.ts)submitSponsorshipIntentsPOST totransaction-sponsorship/intents.src/types.ts,src/constants.ts,src/index.ts)SubmitSponsorshipIntentsRequest/SubmitSponsorshipIntentsMethodParams.CachedLastSelectedPaymentMethod(includes optionalpaymentTokenSymbol).PaymentTokenAddressAndSymbolRequiredForCrypto,PaymentMethodNotCrypto,ProductPriceNotFound; exportACTIVE_SUBSCRIPTION_STATUSES.StartCryptoSubscriptionRequestwith optionalisSponsored,smartTransactionId.minBillingCyclesand yearly price; adjust expectedapproveAmount.submitSponsorshipIntentsmethod.Written by Cursor Bugbot for commit 3387604. This will update automatically on new commits. Configure here.