feat: transaction pay controller #6820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
0e50e56 to
4c6b861
Compare
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
2 times, most recently
from
f286d34 to
1854460
Compare
matthewwalsh0
changed the base branch from
main
to
feat/transaction-controller-intent-complete
matthewwalsh0
changed the base branch from
feat/transaction-controller-intent-complete
to
main
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
3 times, most recently
from
f319b5c to
ab1550f
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
6bf4b22 to
77daf0c
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
fa44f49 to
1d50e78
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
bbdeed2 to
b7ddd1f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
OGPoyraz
previously approved these changes
Oct 30, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
Mrtenz
reviewed
Oct 30, 2025
packages/transaction-pay-controller/src/TransactionPayController.ts
Outdated
Show resolved
Hide resolved
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
previously approved these changes
Oct 30, 2025
matthewwalsh0
dismissed stale reviews from OGPoyraz and FrederikBolding
via
a4e3b6c
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
a4e3b6c to
4d0ac75
Compare
OGPoyraz
approved these changes
Oct 30, 2025
FrederikBolding
approved these changes
Oct 30, 2025
Mrtenz
approved these changes
Oct 30, 2025
|
@metamaskbot publish-preview |
| decimals: number, | ||
| fiatRates: FiatRates, | ||
| ) { | ||
| const amountRawValue = new BigNumber(amountRawInput); |
There was a problem hiding this comment.
do we need to pass 16 here to denote a hexadecimal value?
There was a problem hiding this comment.
If the value starts with 0x, it should be automatic.
|
|
||
| const sourceAmounts = tokens | ||
| .map((t) => calculateSourceAmount(paymentToken, t, messenger)) | ||
| .filter(Boolean) as TransactionPaySourceAmount[]; |
There was a problem hiding this comment.
This filter changes the length of the sourceAmounts array compared to the initial tokens array, this could cause issues on quotes.ts when relying on tokens[i] to select a certain token.
There was a problem hiding this comment.
Good spot, this is probably okay for now since it's the second gas fee token that is most likely to be removed if the user has balance, but safer to lookup by the token address on the source amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add the initial version of the
TransactionPayController.This intends to migrate the majority of the MetaMask Pay functionality from the mobile client, so it can be used without duplication in the extension.
For an architecture overview, see ARCHITECTURE.md.
Includes:
TransactionControllerto submit and wait for quotes.updatePaymentTokenaction / method.References
Checklist
Note
Adds @metamask/transaction-pay-controller to power MetaMask Pay with bridge/relay strategies, automatic required-token detection, quote orchestration, and a TransactionController publish hook.
@metamask/transaction-pay-controller0xa9059cbb, gas fees), selects payment token, computes source amounts, fetches quotes, and aggregates totals.BridgeStrategy: fetches viaBridgeController, submits viaBridgeStatusController, supports batch txs and configurable refresh intervals.RelayStrategy: fetches from Relay API, submits txs directly; supports Hyperliquid/Polygon-native normalization and skip-original-tx flow.TransactionPayPublishHookexecutes strategy quotes on publish and awaits completion.README.md(package list + dependency graph),CODEOWNERS,teams.json.Written by Cursor Bugbot for commit 83d6977. This will update automatically on new commits. Configure here.