Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 9, 2025

Explanation

This PR migrates PermissionLogController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates PermissionLogController to @metamask/messenger, updates types/metadata and exports, adapts tests, and updates configs/changelog.

  • PermissionLogController:
    • Migrate to @metamask/messenger Messenger; use @metamask/base-controller/next types (ControllerGetStateAction, ControllerStateChangeEvent).
    • Define and export PermissionLogControllerMessenger, PermissionLogControllerActions, PermissionLogControllerGetStateAction, PermissionLogControllerEvents, PermissionLogControllerStateChangeEvent.
    • Rename metadata anonymous to includeInDebugSnapshot.
    • Switch index to named exports and re-export new types.
  • Tests:
    • Update to construct root/child messengers from @metamask/messenger and use deriveStateFromMetadata from @metamask/base-controller/next.
  • Package/Config:
    • Add dependency @metamask/messenger@^0.3.0; add TS project references to packages/messenger.
    • Changelog: note BREAKING migration to new Messenger and metadata rename; document new exported types.
  • Docs:
    • README dependency graph: add permission_log_controller --> messenger; minor graph tweak for eip_7702_internal_rpc_middleware.

Written by Cursor Bugbot for commit 2c60018. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/permission-log-controller branch from b5ab756 to f9dc4ff Compare October 7, 2025 10:37
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner October 7, 2025 10:37
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/permission-log-controller branch 2 times, most recently from a743253 to a16ceff Compare October 7, 2025 10:39
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/permission-log-controller branch from a16ceff to b36974e Compare October 7, 2025 10:50
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit ce4c907 Oct 27, 2025
256 of 257 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev-2s/messenger/permission-log-controller branch October 27, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants