refactor: migrate PhishingController to @metamask/messenger

[cryptodev-2s]

Explanation

This PR migrates PhishingController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

• Related to Implement messenger delegation #5626

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Migrates PhishingController to use @metamask/messenger and renames metadata field anonymous to includeInDebugSnapshot.

• Breaking Changes
  • Migrate PhishingController to @metamask/messenger Messenger (replaces RestrictedMessenger from @metamask/base-controller).
  • Rename metadata property anonymous to includeInDebugSnapshot.
• Controller (packages/phishing-controller/src/PhishingController.ts):
  • Switch imports to @metamask/base-controller/next and @metamask/messenger.
  • Replace messagingSystem calls with messenger.registerActionHandler/messenger.subscribe.
  • Update PhishingControllerMessenger type to use Messenger<...>.
• Tests:
  • Update test harness to create root/child messengers via @metamask/messenger and delegate TransactionController:stateChange.
  • Use deriveStateFromMetadata from @metamask/base-controller/next and expect includeInDebugSnapshot.
• Package/Build:
  • Add dependency @metamask/messenger and tsconfig references to packages/messenger.
  • Update README dependency graph to show phishing_controller --> messenger and include @metamask/messenger in package list.

^{Written by Cursor Bugbot for commit c2988bb. This will update automatically on new commits. Configure here.}

[mcmire]

LGTM!

[cursor]

Bug: Missing Type Parameter in Messenger Definition

The PhishingControllerMessenger type definition is missing the fourth type parameter that was present in the old RestrictedMessenger type. The new Messenger type from @metamask/messenger requires a fourth type parameter (parent messenger type) for child messengers. The current definition Messenger<typeof controllerName, PhishingControllerActions | AllowedActions, PhishingControllerEvents | AllowedEvents> should be Messenger<typeof controllerName, PhishingControllerActions | AllowedActions, PhishingControllerEvents | AllowedEvents, ParentMessengerType> where ParentMessengerType is the type of the parent messenger that this controller's messenger is derived from. Without this fourth parameter, the messenger delegation pattern used in tests (lines 84-88 in PhishingController.test.ts) may not work correctly with type safety.