Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 8, 2025

Explanation

This PR migrates SignatureController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates SignatureController to the new @metamask/messenger API, renames the anonymous metadata flag, and updates tests and configs accordingly.

  • Signature Controller:
    • Migrate from RestrictedMessenger (via @metamask/base-controller) to Messenger from @metamask/messenger; replace messagingSystem calls with messenger.call for keyring, approval, logging, network, and accounts actions.
    • Import BaseController (and types) from @metamask/base-controller/next.
    • Rename state metadata key anonymous to includeInDebugSnapshot and update stateMetadata accordingly.
  • Tests:
    • Update to use @metamask/base-controller/next deriveStateFromMetadata and mock SignatureControllerMessenger with messenger.call routing.
    • Adjust assertions for renamed metadata flag.
  • Package/Config:
    • Add dependency @metamask/messenger and reference it in tsconfig project references.
    • Update README dependency graph to show signature_controller --> messenger and add eip_7702_internal_rpc_middleware link.
  • Changelog:
    • Note BREAKING changes: new Messenger type and metadata flag rename.

Written by Cursor Bugbot for commit 9d79954. This will update automatically on new commits. Configure here.

mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/signgature-controller branch from 6c43b23 to 5fb8e7f Compare September 24, 2025 13:49
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/signgature-controller branch from 5fb8e7f to 4a6fc10 Compare October 7, 2025 08:59
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 66d6ae1 Oct 27, 2025
256 of 257 checks passed
@FrederikBolding FrederikBolding deleted the cryptodev-2s/messenger/signgature-controller branch October 27, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants