Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 8, 2025

Explanation

This PR migrates UserOperationController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates UserOperationController to use @metamask/messenger, updates BaseController vNext types, renames metadata anonymous to includeInDebugSnapshot, and adjusts tests/configs/deps.

  • UserOperationController
    • Migrate from RestrictedMessenger to new Messenger (@metamask/messenger); replace messagingSystem calls with messenger.
    • Adopt @metamask/base-controller/next types (ControllerGetStateAction, ControllerStateChangeEvent).
    • Rename state metadata anonymous -> includeInDebugSnapshot.
    • Construct SnapSmartContractAccount with messenger; fetch provider via messenger.call.
  • Tests
    • Update imports to @metamask/base-controller/next and expectations for includeInDebugSnapshot; mock messenger interface.
  • Dependencies/Config
    • Add dependency @metamask/messenger@^0.3.0 and TS project references; update README dependency graph.
  • Changelog
    • Document BREAKING changes: new Messenger requirement and metadata key rename.

Written by Cursor Bugbot for commit 17d8f13. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested review from a team as code owners September 8, 2025 13:09
@cryptodev-2s cryptodev-2s self-assigned this Sep 8, 2025
@cryptodev-2s cryptodev-2s mentioned this pull request Sep 4, 2025
43 tasks
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/user-operation-controller branch 3 times, most recently from f9b5ad6 to 470cc89 Compare September 8, 2025 13:53
mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/user-operation-controller branch from 470cc89 to 18fb3a3 Compare September 24, 2025 12:41
@cryptodev-2s cryptodev-2s requested review from a team and mcmire September 24, 2025 12:44
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/user-operation-controller branch from 574b4d8 to 1dc59c0 Compare October 7, 2025 08:55
mcmire
mcmire previously approved these changes Oct 7, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit bf60e5e Oct 27, 2025
256 of 257 checks passed
@FrederikBolding FrederikBolding deleted the cryptodev-2s/messenger/user-operation-controller branch October 27, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants