Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 4, 2025

Explanation

This PR migrates LoggingController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates LoggingController to @metamask/messenger, renames metadata key anonymous to includeInDebugSnapshot, and updates tests/configs accordingly.

  • Logging Controller
    • Migrate to @metamask/messenger and @metamask/base-controller/next; register actions via messenger.registerActionHandler.
    • Update metadata: replace anonymous with includeInDebugSnapshot and type with StateMetadata.
    • Update type aliases to use Messenger instead of RestrictedMessenger.
    • Add dependency @metamask/messenger@^0.3.0 and TS project references.
    • Changelog: mark BREAKING changes for messenger migration and metadata key rename.
  • Tests
    • Rewrite messenger setup using root/child Messenger from @metamask/messenger and update imports from @metamask/base-controller/next.
    • Adjust calls to LoggingController:add via root messenger.
  • Repo Docs/Graph
    • Dependency graph: add logging_controller --> messenger; add eip_7702_internal_rpc_middleware --> controller_utils.
  • Lockfile
    • Update for new @metamask/messenger dependency.

Written by Cursor Bugbot for commit 28d9e41. This will update automatically on new commits. Configure here.

@mikesposito mikesposito marked this pull request as ready for review September 4, 2025 12:17
@mikesposito mikesposito requested review from a team as code owners September 4, 2025 12:17
@mikesposito mikesposito mentioned this pull request Sep 4, 2025
43 tasks
mcmire
mcmire previously approved these changes Sep 10, 2025
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito enabled auto-merge October 27, 2025 10:43
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 36b9c65 Oct 27, 2025
256 of 257 checks passed
@mikesposito mikesposito deleted the mikesposito/messenger/logging-controller branch October 27, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants