Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 4, 2025

Explanation

This PR migrates GatorPermissionsController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates GatorPermissionsController to @metamask/messenger, updates Base Controller imports/metadata, refactors tests, and wires package/graph updates.

  • Breaking changes:
    • Move from RestrictedMessenger (via @metamask/base-controller) to Messenger from @metamask/messenger in GatorPermissionsController and tests.
    • Rename state metadata key anonymous to includeInDebugSnapshot; switch imports to @metamask/base-controller/next.
  • Controller (packages/gator-permissions-controller/src/GatorPermissionsController.ts):
    • Replace messagingSystem usages with messenger (registerActionHandler, call).
    • Update GatorPermissionsControllerMessenger type to use Messenger.
    • Preserve state shape; keep getters/actions; no behavior change beyond messenger plumbing.
  • Tests (packages/gator-permissions-controller/src/GatorPermissionsController.test.ts):
    • Refactor to new Messenger types/utilities; introduce root/delegated messenger setup; update metadata tests to includeInDebugSnapshot.
  • Package config:
    • Add dependency @metamask/messenger and TypeScript project references to packages/messenger.
  • Docs/graph:
    • Update README dependency graph to show base_controller --> messenger and gator_permissions_controller --> messenger; add eip_7702_internal_rpc_middleware edge.
  • Changelog:
    • Note breaking migration to @metamask/messenger and metadata rename under Unreleased.

Written by Cursor Bugbot for commit 15b0e0c. This will update automatically on new commits. Configure here.

@mikesposito mikesposito marked this pull request as ready for review September 4, 2025 11:05
@mikesposito mikesposito requested review from a team as code owners September 4, 2025 11:05
@mikesposito mikesposito mentioned this pull request Sep 4, 2025
43 tasks
mcmire
mcmire previously approved these changes Sep 10, 2025
cursor[bot]

This comment was marked as outdated.

@mikesposito mikesposito force-pushed the mikesposito/messenger/gator-permissions-controller branch from 2a9f4cb to 1ce55a6 Compare September 23, 2025 14:25
@mcmire
Copy link
Contributor

mcmire commented Oct 7, 2025

Need to resolve conflicts :(

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito enabled auto-merge October 27, 2025 10:40
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit bfb8cbb Oct 27, 2025
256 of 257 checks passed
@mikesposito mikesposito deleted the mikesposito/messenger/gator-permissions-controller branch October 27, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants