Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 3, 2025

Explanation

This PR migrates the EarnController class to the new @metamask/messenger comm system, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates EarnController from RestrictedMessenger to @metamask/messenger, updates state metadata keys, and aligns tests, configs, and docs.

  • EarnController:
    • Migrate messaging from RestrictedMessenger to @metamask/messenger with new typed Messenger and delegate usage; replace messagingSystem calls with messenger.call/subscribe.
    • Update imports to @metamask/base-controller/next.
    • Rename metadata key anonymous to includeInDebugSnapshot and adjust values.
  • Tests (packages/earn-controller/src/EarnController.test.ts):
    • Switch to @metamask/messenger root and namespaced messengers; update types; adjust deriveStateFromMetadata selector to includeInDebugSnapshot.
  • Package/Config:
    • Add dependency @metamask/messenger and TS project references.
  • Docs:
    • Update dependency graph in README.md to link earn_controllermessenger and add eip_7702_internal_rpc_middlewarecontroller_utils.
  • Changelog:
    • Note breaking changes: new Messenger requirement and metadata key rename.

Written by Cursor Bugbot for commit ba9bcec. This will update automatically on new commits. Configure here.

@mikesposito mikesposito mentioned this pull request Sep 3, 2025
43 tasks
@mikesposito mikesposito marked this pull request as ready for review September 3, 2025 16:58
@mikesposito mikesposito requested review from a team as code owners September 3, 2025 16:58
@mikesposito mikesposito force-pushed the mikesposito/messenger/earn-controller branch from 460f754 to ca596a3 Compare September 3, 2025 21:46
@mikesposito mikesposito requested review from a team as code owners September 3, 2025 21:46
@mikesposito mikesposito force-pushed the mikesposito/messenger/earn-controller branch from ca596a3 to 307c886 Compare September 3, 2025 21:52
ffmcgee725
ffmcgee725 previously approved these changes Sep 4, 2025
Copy link
Member

@ffmcgee725 ffmcgee725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcmire
mcmire previously approved these changes Sep 10, 2025
@mikesposito mikesposito dismissed stale reviews from mcmire and ffmcgee725 via 24d9bf0 September 23, 2025 13:44
@mikesposito mikesposito enabled auto-merge (squash) September 23, 2025 13:45
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito disabled auto-merge October 27, 2025 10:37
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 0de0405 Oct 27, 2025
256 of 257 checks passed
@FrederikBolding FrederikBolding deleted the mikesposito/messenger/earn-controller branch October 27, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants