feat: Add messenger delegate and revoke methods
#6132
Draft
+1,240
−2,006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
create-messenger-package
branch
2 times, most recently
from
4876850 to
e3899db
Compare
Gudahtt
force-pushed
the
add-messenger-delegation
branch
from
06e8700 to
4773644
Compare
The methods `delegate` and `revoke` have been added to the Messenger class. These methods replace the need for the `RestrictedMessenger`. The `getRestricted` method, and the `RestrictedMessenger` class, have been removed as obsolete. See this ADR PR for details: MetaMask/decisions#53
Gudahtt
force-pushed
the
add-messenger-delegation
branch
from
4773644 to
a104532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The methods
delegateandrevokehave been added to the Messenger class. These methods replace the need for theRestrictedMessenger. ThegetRestrictedmethod, and theRestrictedMessengerclass, have been removed as obsolete.Note that the
parentconstructor parameter described in the ADR is not implemented yet, that will come in the next PR.References
See this ADR PR for details: MetaMask/decisions#53
Checklist