Skip to content

feat: fallback to node with overrides for type-4 gas estimation #6016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

matthewwalsh0
Copy link
Member

Explanation

Currently, gas estimations for type-4 transactions with data are done using the simulation API only.

This adds a fallback to use eth_estimateGas with state overrides if the simulation fails, due to the chain not being supported for example.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner June 20, 2025 20:55
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner June 20, 2025 20:57
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) June 24, 2025 10:21
@matthewwalsh0 matthewwalsh0 force-pushed the feat/type-4-gas-node-overrides branch from d742a49 to 01e543c Compare June 24, 2025 10:21
@matthewwalsh0 matthewwalsh0 merged commit c000c3e into main Jun 24, 2025
209 of 210 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/type-4-gas-node-overrides branch June 24, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants