Reduce default circuit break duration to 2 minutes #6015
+123
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
downgrade-circuit-break-duration
branch
2 times, most recently
from
5718d02 to
716218f
Compare
The `createServicePolicy` utility sets the default "circuit break duration" to 30 minutes. When used to hit an API, this signifies the amount of time requests to that API that will be paused if it consistently responds with enough 500s. Since the `createServicePolicy` utility is used to make network requests, however, it also signifies the amount of time that users will be "locked out" from interacting with a blockchain until requests respond successfully. Pausing for 30 minutes makes sense if an RPC endpoint is truly down, but it creates a major inconvenience if the endpoint mostly works and only certain kinds of requests fail. To address this, this commit reduces the default circuit break duration to 2 minutes to allow for faster recovery.
mcmire
force-pushed
the
downgrade-circuit-break-duration
branch
from
716218f to
e14ff4b
Compare
mcmire
commented
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the "circuit break duration" — the duration for which requests to an RPC endpoint are paused when the endpoint is perceived to be unavailable — is 30 minutes. This is a good value when a true outage exists, but if the endpoint is merely degraded or is returning 500s for specific requests then we don't want to lock users out of their wallet for a long time. To accommodate these cases, this commit reduces the circuit break duration to 2 minutes so that recovery is faster.
References
Closes #5887.
Checklist