Skip to content

chore: make networkClientId mandatory field in assetsContractController #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: make networkClientId mandatory field in assetsContractController #5941

wants to merge 10 commits into from

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jun 9, 2025 •
edited by Prithpal-Sooriya
Loading

Explanation

PR to make networkClientId mandatory in AssetsContractController.

TEST DRIVE PRs:

  • EXTENSION:
  • MOBILE:

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@sahar-fehri sahar-fehri mentioned this pull request Jun 9, 2025
Closed
4 tasks
@sahar-fehri sahar-fehri force-pushed the chore/make-networkClientId-mandatory-in-assets-contract-controller branch from b9477f0 to 5de828d Compare June 9, 2025 11:50
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/account-tree-controller": "0.1.0-preview-e11fb169",
  "@metamask-previews/accounts-controller": "30.0.0-preview-e11fb169",
  "@metamask-previews/address-book-controller": "6.1.0-preview-e11fb169",
  "@metamask-previews/announcement-controller": "7.0.3-preview-e11fb169",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-e11fb169",
  "@metamask-previews/approval-controller": "7.1.3-preview-e11fb169",
  "@metamask-previews/assets-controllers": "68.1.0-preview-e11fb169",
  "@metamask-previews/base-controller": "8.0.1-preview-e11fb169",
  "@metamask-previews/bridge-controller": "32.1.1-preview-e11fb169",
  "@metamask-previews/bridge-status-controller": "29.1.0-preview-e11fb169",
  "@metamask-previews/build-utils": "3.0.3-preview-e11fb169",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-e11fb169",
  "@metamask-previews/composable-controller": "11.0.0-preview-e11fb169",
  "@metamask-previews/controller-utils": "11.10.0-preview-e11fb169",
  "@metamask-previews/delegation-controller": "0.4.0-preview-e11fb169",
  "@metamask-previews/earn-controller": "1.1.0-preview-e11fb169",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-e11fb169",
  "@metamask-previews/ens-controller": "16.0.0-preview-e11fb169",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-e11fb169",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-e11fb169",
  "@metamask-previews/foundryup": "1.0.0-preview-e11fb169",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-e11fb169",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-e11fb169",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-e11fb169",
  "@metamask-previews/keyring-controller": "22.0.2-preview-e11fb169",
  "@metamask-previews/logging-controller": "6.0.4-preview-e11fb169",
  "@metamask-previews/message-manager": "12.0.1-preview-e11fb169",
  "@metamask-previews/multichain": "4.1.0-preview-e11fb169",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-e11fb169",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-e11fb169",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-e11fb169",
  "@metamask-previews/name-controller": "8.0.3-preview-e11fb169",
  "@metamask-previews/network-controller": "23.6.0-preview-e11fb169",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-e11fb169",
  "@metamask-previews/permission-controller": "11.0.6-preview-e11fb169",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-e11fb169",
  "@metamask-previews/phishing-controller": "12.5.0-preview-e11fb169",
  "@metamask-previews/polling-controller": "13.0.0-preview-e11fb169",
  "@metamask-previews/preferences-controller": "18.1.0-preview-e11fb169",
  "@metamask-previews/profile-sync-controller": "17.0.0-preview-e11fb169",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-e11fb169",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-e11fb169",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-e11fb169",
  "@metamask-previews/sample-controllers": "0.1.0-preview-e11fb169",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-e11fb169",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-e11fb169",
  "@metamask-previews/signature-controller": "30.0.0-preview-e11fb169",
  "@metamask-previews/token-search-discovery-controller": "3.2.0-preview-e11fb169",
  "@metamask-previews/transaction-controller": "57.2.0-preview-e11fb169",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-e11fb169"
}

@sahar-fehri sahar-fehri marked this pull request as ready for review June 10, 2025 12:21
@sahar-fehri sahar-fehri requested review from a team as code owners June 10, 2025 12:21
@salimtb
Copy link
Contributor

salimtb commented Jun 10, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/account-tree-controller": "0.1.0-preview-f9611039",
  "@metamask-previews/accounts-controller": "30.0.0-preview-f9611039",
  "@metamask-previews/address-book-controller": "6.1.0-preview-f9611039",
  "@metamask-previews/announcement-controller": "7.0.3-preview-f9611039",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-f9611039",
  "@metamask-previews/approval-controller": "7.1.3-preview-f9611039",
  "@metamask-previews/assets-controllers": "68.1.0-preview-f9611039",
  "@metamask-previews/base-controller": "8.0.1-preview-f9611039",
  "@metamask-previews/bridge-controller": "32.1.1-preview-f9611039",
  "@metamask-previews/bridge-status-controller": "29.1.0-preview-f9611039",
  "@metamask-previews/build-utils": "3.0.3-preview-f9611039",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-f9611039",
  "@metamask-previews/composable-controller": "11.0.0-preview-f9611039",
  "@metamask-previews/controller-utils": "11.10.0-preview-f9611039",
  "@metamask-previews/delegation-controller": "0.4.0-preview-f9611039",
  "@metamask-previews/earn-controller": "1.1.0-preview-f9611039",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-f9611039",
  "@metamask-previews/ens-controller": "16.0.0-preview-f9611039",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-f9611039",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-f9611039",
  "@metamask-previews/foundryup": "1.0.0-preview-f9611039",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-f9611039",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-f9611039",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-f9611039",
  "@metamask-previews/keyring-controller": "22.0.2-preview-f9611039",
  "@metamask-previews/logging-controller": "6.0.4-preview-f9611039",
  "@metamask-previews/message-manager": "12.0.1-preview-f9611039",
  "@metamask-previews/multichain": "4.1.0-preview-f9611039",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-f9611039",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-f9611039",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-f9611039",
  "@metamask-previews/name-controller": "8.0.3-preview-f9611039",
  "@metamask-previews/network-controller": "23.6.0-preview-f9611039",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-f9611039",
  "@metamask-previews/permission-controller": "11.0.6-preview-f9611039",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-f9611039",
  "@metamask-previews/phishing-controller": "12.5.0-preview-f9611039",
  "@metamask-previews/polling-controller": "13.0.0-preview-f9611039",
  "@metamask-previews/preferences-controller": "18.1.0-preview-f9611039",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-f9611039",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-f9611039",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-f9611039",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-f9611039",
  "@metamask-previews/sample-controllers": "0.1.0-preview-f9611039",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-f9611039",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-f9611039",
  "@metamask-previews/signature-controller": "30.0.0-preview-f9611039",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-f9611039",
  "@metamask-previews/transaction-controller": "57.2.0-preview-f9611039",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-f9611039"
}

salimtb
salimtb approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview build tested and approved

@Prithpal-Sooriya
Copy link
Contributor

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-7a575715",
  "@metamask-previews/accounts-controller": "30.0.0-preview-7a575715",
  "@metamask-previews/address-book-controller": "6.1.0-preview-7a575715",
  "@metamask-previews/announcement-controller": "7.0.3-preview-7a575715",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-7a575715",
  "@metamask-previews/approval-controller": "7.1.3-preview-7a575715",
  "@metamask-previews/assets-controllers": "68.1.0-preview-7a575715",
  "@metamask-previews/base-controller": "8.0.1-preview-7a575715",
  "@metamask-previews/bridge-controller": "32.1.2-preview-7a575715",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-7a575715",
  "@metamask-previews/build-utils": "3.0.3-preview-7a575715",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-7a575715",
  "@metamask-previews/composable-controller": "11.0.0-preview-7a575715",
  "@metamask-previews/controller-utils": "11.10.0-preview-7a575715",
  "@metamask-previews/delegation-controller": "0.4.0-preview-7a575715",
  "@metamask-previews/earn-controller": "1.1.0-preview-7a575715",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-7a575715",
  "@metamask-previews/ens-controller": "16.0.0-preview-7a575715",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-7a575715",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-7a575715",
  "@metamask-previews/foundryup": "1.0.0-preview-7a575715",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-7a575715",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-7a575715",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-7a575715",
  "@metamask-previews/keyring-controller": "22.0.2-preview-7a575715",
  "@metamask-previews/logging-controller": "6.0.4-preview-7a575715",
  "@metamask-previews/message-manager": "12.0.1-preview-7a575715",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-7a575715",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-7a575715",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-7a575715",
  "@metamask-previews/name-controller": "8.0.3-preview-7a575715",
  "@metamask-previews/network-controller": "23.6.0-preview-7a575715",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-7a575715",
  "@metamask-previews/permission-controller": "11.0.6-preview-7a575715",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-7a575715",
  "@metamask-previews/phishing-controller": "12.6.0-preview-7a575715",
  "@metamask-previews/polling-controller": "13.0.0-preview-7a575715",
  "@metamask-previews/preferences-controller": "18.1.0-preview-7a575715",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-7a575715",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-7a575715",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-7a575715",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-7a575715",
  "@metamask-previews/sample-controllers": "0.1.0-preview-7a575715",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-7a575715",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-7a575715",
  "@metamask-previews/signature-controller": "30.0.0-preview-7a575715",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-7a575715",
  "@metamask-previews/transaction-controller": "57.3.0-preview-7a575715",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-7a575715"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@salimtb salimtb salimtb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahar-fehri @salimtb @Prithpal-Sooriya