-
-
Notifications
You must be signed in to change notification settings - Fork 234
Migrate ApprovalController to BaseControllerV2 #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcad6c7
to
2ecb8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two inaccurate comments should be cleaned up, but everything looks great otherwise!
} | ||
|
||
// These signatures create a meaningful difference when this method is called. | ||
/* eslint-disable @typescript-eslint/unified-signatures */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I lean more towards unified signatures here as well 🤔 The separate descriptions are kinda nice, but we could explain both origin and type in the unified signature. This seems like it would be more burdensome to maintain.
But I'd be OK with us trying this anyway if you'd prefer. I've never tried it before. Not a big deal 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may make it somewhat more burdensome to maintain, but I think it does make the method easier to use. We can always get rid of the signatures in the future, if it's too much. Since the implementation is very permissive with its parameters, it shouldn't be breaking.
f78d501
to
4d5be86
Compare
Meh, I decided against it. The |
4d5be86
to
00e7f37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR migrates the `ApprovalController` to `BaseControllerV2`. Its functionality is exactly the same as before, with the exception of some name changes for clarity, and the addition of controller messenger actions. The method `resolve` has been renamed to `accept`, which is a breaking change.
This PR migrates the `ApprovalController` to `BaseControllerV2`. Its functionality is exactly the same as before, with the exception of some name changes for clarity, and the addition of controller messenger actions. The method `resolve` has been renamed to `accept`, which is a breaking change.
This PR migrates the
ApprovalController
toBaseControllerV2
. Its functionality is exactly the same as before, with the exception of some name changes for clarity, and the addition of controller messenger actions.The method
resolve
has been renamed toaccept
, which is a breaking change.