Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert eth-sig-util package #5027

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Dec 5, 2024

Explanation

The recent changes in the eth-sig-util package was adding schema was too strict for Permit type of signatures hence we need to revert change.

References

Changelog

@metamask/signature-controller

  • Changed: Revert back to eth-sig-util@8.0.0

@metamask/message-manager

  • Changed: Revert back to eth-sig-util@8.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@OGPoyraz OGPoyraz requested review from a team as code owners December 5, 2024 16:01
@OGPoyraz OGPoyraz enabled auto-merge (squash) December 5, 2024 16:12
@OGPoyraz OGPoyraz merged commit fbe0bc0 into main Dec 5, 2024
120 checks passed
@OGPoyraz OGPoyraz deleted the fix/revert-eth-sig-util-package branch December 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants