Skip to content

Conversation

@matthewwalsh0
Copy link
Member

Explanation

Remove dependency on @metamask/keyring-api from @metamask/transaction-controller as it was only used for types in unit tests.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 21, 2024 10:04
@matthewwalsh0 matthewwalsh0 requested a review from a team November 21, 2024 10:04
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) November 21, 2024 11:10
@matthewwalsh0 matthewwalsh0 merged commit 72a75a5 into main Nov 21, 2024
120 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/transaction-controller-remove-keyring-api-dependency branch November 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants