Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token rates controller for multi evm fetching #4866

Merged
merged 14 commits into from
Nov 1, 2024
Merged

Update token rates controller for multi evm fetching #4866

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
15343f0
use multi api for currency rates
bergeron Oct 25, 2024
9e22b9b
fix unit tests
bergeron Oct 25, 2024
14f00a1
multichain token rates
bergeron Oct 29, 2024
1e2acce
lint
bergeron Oct 29, 2024
596fc17
Merge branch 'main' of github.com:MetaMask/core into brian/multichain…
bergeron Oct 29, 2024
1b5bcd7
insert null values when currency is not suppored, to maintain existin…
bergeron Oct 29, 2024
252be41
fix dedupe logic
bergeron Oct 29, 2024
c6d939c
Merge branch 'brian/multichain-currency-rates' into brian/multichain-…
bergeron Oct 29, 2024
fa7d96b
only fetch on chains whose tokens updated
bergeron Oct 29, 2024
27b1dc9
Merge branch 'main' into brian/multichain-token-rates
bergeron Oct 30, 2024
7c7544d
Update TokenRatesController.ts
bergeron Oct 31, 2024
699c6b6
fix chain id
bergeron Oct 31, 2024
dc2d8ea
fix: fix unit test
sahar-fehri Oct 31, 2024
b3451c2
Merge branch 'main' into brian/multichain-token-rates
sahar-fehri Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dedupe logic
  • Loading branch information
@bergeron
bergeron committed Oct 29, 2024
commit 252be41dd438e251e93eb68a74ec63df7c4254d5
4 changes: 2 additions & 2 deletions packages/assets-controllers/src/CurrencyRateController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export class CurrencyRateController extends StaticIntervalPollingController<Curr
// For preloaded testnets (Goerli, Sepolia) we want to fetch exchange rate for real ETH.
// Map each native currency to the symbol we want to fetch for it.
const testnetSymbols = Object.values(TESTNET_TICKER_SYMBOLS);
const nativeCurrenciesToFetch = [...new Set(nativeCurrencies)].reduce(
const nativeCurrenciesToFetch = nativeCurrencies.reduce(
(acc, nativeCurrency) => {
acc[nativeCurrency] = testnetSymbols.includes(nativeCurrency)
? FALL_BACK_VS_CURRENCY
Expand All @@ -177,7 +177,7 @@ export class CurrencyRateController extends StaticIntervalPollingController<Curr

const fetchExchangeRateResponse = await this.fetchMultiExchangeRate(
currentCurrency,
Object.values(nativeCurrenciesToFetch),
[...new Set(Object.values(nativeCurrenciesToFetch))],
this.includeUsdRate,
);

Expand Down
Loading