feat: update currency rate controller polling input #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gambinish
approved these changes
Oct 23, 2024
| @@ -155,7 +155,7 @@ describe('CurrencyRateController', () => { | |||
| messenger, | |||
| }); | |||
|
|
|||
| controller.startPolling({ networkClientId: 'mainnet' }); | |||
| controller.startPolling({ nativeCurrency: 'ETH' }); | |||
There was a problem hiding this comment.
Wondering why we are using the symbol here rather than an address of some sort?
There was a problem hiding this comment.
the currency rate controller handles prices for the native gas token of each chain. They're identified by symbol.
salimtb
approved these changes
Oct 23, 2024
sahar-fehri
approved these changes
Oct 23, 2024
|
@metamaskbot publish-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Prepares the currency rate controller to be polled across chains. We want a unique polling loop for each unique native currency (e.g. ETH, BNB). Rather than for each network client id. So this PR updates the polling input to
{nativeCurrency: string}References
Changelog
@metamask/assets-controllersCurrencyRateControllerpolling input is now{nativeCurrency: string}instead of a network client id.Checklist